MWCS: check if REF stack present #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ashton, Thanks for the PR. About the code itself, I don't really like the "continue" as is, this REF missing case. At least add some logging.debug("") statement or something similar. Also, please put your name in the list in the alphabetical order. |
|
Yea, its more of a bandaid maybe. Maybe worth checking to see if the
relevant daily seismograms are in the database. If they are there then
could add a catch to say something messed up long the way, and if there not
there then proceed with the continue
…On Thu, Oct 18, 2018, 11:27 PM Thomas Lecocq ***@***.***> wrote:
Ashton,
Thanks for the PR.
About the code itself, I don't really like the "continue" as is, this REF
missing case. At least add some logging.debug("") statement or something
similar.
Also, please put your name in the list in the alphabetical order.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGVij6luHdQpSM6FnDgc47KRrnmkU9K-ks5umXDVgaJpZM4Xua9Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change added to compute_mwcs, to check for reference file existence at each component step so it doesnt crash if the component is missing.